Bind ASIC database instances to midplane IPs #20803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@arlakshm for awareness |
Collaborator
|
Tracking issue: sonic-net/SONiC#1543 |
Contributor
|
Please add more details how what problem is PR is trying to solve |
arlakshm
reviewed
Nov 15, 2024
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vmittal-msft
approved these changes
Jan 22, 2025
Contributor
vmittal-msft
left a comment
vmittal-msft
left a comment
There was a problem hiding this comment.
Please make sure these changes don't impact T0/T1 device.
Contributor
Author
We have this merged internally for a few weeks now and we haven't seen any regression on T0/T1 devices. |
Contributor
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@rlhui could you help merge |
Contributor
builds not passing |
Contributor
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@rlhui please could you merge this PR |
yanjundeng
pushed a commit
to yanjundeng/sonic-buildimage
that referenced
this pull request
Apr 23, 2025
This feature has been tracked in sonic-net#1543 HLD PR: 1957 Why I did it Add support for aggregate VOQ counters.
vidyac86
pushed a commit
to vidyac86/sonic-buildimage
that referenced
this pull request
Apr 23, 2025
This feature has been tracked in sonic-net#1543 HLD PR: 1957 Why I did it Add support for aggregate VOQ counters.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature has been tracked in #1543
HLD PR: 1957
Why I did it
Add support for aggregate VOQ counters.
Work item tracking
How I did it
Bound ASIC redis database instances on linecards to IPs in midplane subnet (in addition to lo and docker network IPs) so that they are accessible from supervisor and queuestat can access those and aggregate VOQ counters.
CLI changes: #3617
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)